[OpenWrt-Devel] [PATCH 6/6] ramips: mt7621: disable ISDN in kernel config

[Nikolay Martynov]

2015-12-14 4:54 GMT-05:00 Felix Fietkau <nbd at openwrt.org>:
> On 2015-12-14 04:04, Nikolay Martynov wrote:
>> It's unlikely that devices on this SoC would need any ISDN support.
>> This should make kernel a bit smaller.
>>
>> Signed-off-by: Nikolay Martynov <mar.kolya at gmail.com>
> NACK from me on this one. I don't want people to fill up the target
> configs with random arbitrary overrides based on what kind of use cases
> people think may or may not be possible with devices from that target.
>
> If CONFIG_ISDN really does have an effect on kernel size, there should
> be a generic way to deal with this, or a way to confine the size impact
> on the actual kernel modules using it.
>
> Did you find any actual size impact in your tests, or were you just
> guessing?

  Please feel free to drop this.
  I've just done some measurements and it looks like it's 1 page a
most, and it's probably stripped after that.
  It's just somewhat to see ISDN in configs nowdays and it looks like
other targets' configs drop this support.

  Sorry, should have checked size effects before submitting.

-- 
Martynov Nikolay.
Email: mar.kolya at gmail.com
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel