[OpenWrt-Devel] [PATCH 1/9] ar71xx: PowerCloud CAP324 kernel support To: openwrt-devel at lists.openwrt.org

[Felix Fietkau]

On 2015-12-09 21:02, Daniel Dickinson wrote:
>> Seems like we've been accumulating separate patches for adding
>> individual boards again, I'm going to clean up that stuff later. When
>> you've fixed the issues that I've pointed out already, please also
>> restructure your patches to add the mach files individually, then a
>> commit that integrates your boards into
>> 700-MIPS-ath79-openwrt-machines.patch, then the image build integration
>> patches.
> 
> 
> Sorry, I'm not 100% sure I follow, so let me make sure I'm understanding:
> 
> You no longer want to have individual patches in 
> target/linux/xxx/patches/ for each board, so the commit series should be to
> 
> do each board separately in terms of commit, but which each affect 
> 700-MIPS-ath79-openwrt-machines.patch rather than being in individual 
> patches.
> 
> That is the adding mach-xxx.c becomes part of 700-MIPS-ath79-... ?
mach-xxx.c should go to files/arch/mips/ath79/ instead of patches/

> Or should the mach file be added somewhere else (e.g. somewhere in the 
> target/linux/ar71xx tree and referenced by patch 700-MIPS-... for the 
> KConfig and Makefile and so on?
> 
> 
> It would be perhaps useful to have some documentation on dev.openwrt.org 
> pointing to expected board patch guidelines.
This mess really is ar71xx specific. On targets that have been converted
to device tree (e.g. ramips), things are a lot easier and cleaner.
Maybe some day ar71xx will be converted to run device tree too, but I'm
not sure if anybody's actively working on this.

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel