[OpenWrt-Devel] Fwd: Re: [PATCH 10/10] brcmfmac: Add support for multiple PCIE devices in nvram.

[Rafał Miłecki]

On 24 April 2015 at 10:18, Hante Meuleman <meuleman at broadcom.com> wrote:
> Do you want the patch on top of
>
> target/linux/bcm53xx/patches-3.18/110-firmware-backport-NVRAM-driver.patch
>
> Or on top of the unpatched
>
> drivers/firmware/broadcom/bcm47xx_nvram.c
>
> Or on top of the kernel driver file where 110-firmware....patch
> already has been applied?
>
> Or on top of the file
>
> target/linux/bcm53xx/files/drivers/firmware/Broadcom/bcm47xx_nvram.c
>
> The latter would be the easiest, but it probably breaks the 110 patch.
>
> In upstream kernels the bcm47xx_nvram is not part of the kernel,
> this made me believe that it was generated with a patch file.
> Didn’t realize that the OpenWRT also has a files directory from
> which the additional kernel drivers get "injected" in the kernel:
>
> target/linux/bcm53xx/files/drivers/firmware/broadcom
>
> Still this makes me believe they are openwrt specific kernel file,
> but I guess, that is just how one wants to read this sentence.

NVRAM driver is part of upstream kernel, it's just living in arch/mips/ for now:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/bcm47xx/nvram.c

bcm53xx's file is just a copy of above and that would be the best to
keep it this way.

I think you may prepare patch on top of
drivers/firmware/broadcom/bcm47xx_nvram.c for now, then we can work on
upstreaming it. Meanwhile I'll be happy to add your patch to
/home/zajec/openwrt/openwrt.git/target/linux/bcm53xx/patches-3.18/

It doesn't matter if you work on top of
110-firmware-backport-NVRAM-driver.patch, it doesn't even touch
(bcm47xx_)nvram.c.
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel