[OpenWrt-Devel] [PATCH/RFC] [tools] toolchain: ensure tools are built and staged before preparing toolchain

John Szakmeister john at szakmeister.net
Wed Sep 17 15:00:33 EDT 2014


This fixes an issue where the toolchain/prepare step could run, but some
of the necessary host tools might be missing.

Signed-off-by: John Szakmeister <john at szakmeister.net>
---
I found that on two systems I could reliably make the build fail
with multiple jobs.  It turns out that some of the host tools
being built are needed during the prepare step for the
toolchain.  So let's add tools/install as a dependency to that
step to ensure all the tools are available for use.

With this in place, I can see that the tools are all being built
first, and then the build migrates to building the toolchain, as
expected.

I've marked this as RFC because I'm still wrapping my head
around OpenWRT's build system.  It could be there's a better way
to state this dependency, but I'm unaware of what that way would
be.

-John

 toolchain/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/toolchain/Makefile b/toolchain/Makefile
index 36c6ed3..f534cbc 100644
--- a/toolchain/Makefile
+++ b/toolchain/Makefile
@@ -74,7 +74,7 @@ endif
 
 # prerequisites for the individual targets
 $(curdir)/ := .config prereq
-$(curdir)//prepare = $(STAGING_DIR)/.prepared $(TOOLCHAIN_DIR)/info.mk
+$(curdir)//prepare = $(STAGING_DIR)/.prepared $(TOOLCHAIN_DIR)/info.mk tools/install
 $(curdir)//compile = $(1)/prepare
 $(curdir)//install = $(1)/compile
 
-- 
2.1.0
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list