[OpenWrt-Devel] [PATCH][RFC] libubus: restore uloop_cancelled on timeout

[Felix Fietkau]

On 2014-09-15 14:42, Alexandru Ardelean wrote:
> Context: 1 loop with a single ubus_invoke() that times out calls
> uloop_end() which ends the loop, and thus ends the application.
> 
> In the end that seems to confuse procd which outputs a
> notification as if the application segfault-ed a couple of
> times, rather than ended 'gracefully' by being cancelled.
> 
> Not sure if this fix is correct, hence the RFC part.
> 
> Another approach would be to increase the timeout of the ubus_invoke() 
> call in my application, however, that itself does not look like a 
> definitive fix for timing out and cancelling the main uloop.
> 
> So, if there are better suggestions, I'm open for them as well.
> Another idea, would be to 'restart' the main uloop in case of
> the timeout, or cancel the uloop cancel.
Looks good to me, applied to git.

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel