[OpenWrt-Devel] [PATCH] babeld: use procd to start, stop, and respawn

[Tristan Plumb]

Baptiste Jonglez wrote:
> Note that babeld is maintained in https://github.com/openwrt-routing/packages.
> Nevertheless, comments inline.

So I found, after I had sent this off. In future I'll send pull-requests
there.

>> adds a hotplug.d file to restart babeld when interfaces go up or down.
> 
> Somebody provided a patch for this just a few days ago, see:
> 
>   https://github.com/openwrt-routing/packages/pull/52
> 
> However, see the comments: this should not be needed, as babeld detects
> when an interface is brought up and then starts using it.  What is your
> use-case?

I found that (without procd support, I suppose I didn't try it with
procd) babeld was started before some of its logical interfaces that it
is meant to use were had physical interfaces assigned to them. So it'd be
listening to eth0 and 'mesh' which would never appear.


Felix Fietkau wrote:
>> As Gabriel mentioned, the issue is with procd being unable to pass an
>> empty argument.  A simple workaround would be to hack babeld to
>> interpret "-I none" as a synonym of "-I ''", but this issue should
>> really be fixed in procd.
> If I understand the issue correctly, this patch should fix it - please
> test.

Yes, that is exactly it. I went looking for it in the wrong spot.

And now tested.



Which trims down the patch considerably, I'll resubmit my init script
changes to the routing feed, as mentioned above.

Thank you all,
Tristan

-- 
All original matter is hereby placed immediately under the public domain.
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel