[OpenWrt-Devel] [Babel-users] [PATCH] babeld: use procd to start, stop, and respawn

[John Crispin]

On 09/09/2014 18:18, Dave Taht wrote:
> On Tue, Sep 9, 2014 at 9:01 AM, Juliusz Chroboczek
> <jch at pps.univ-paris-diderot.fr> wrote:
>> [Felix, John, we're discussing the integration of babeld (a routing daemon)
>>  with procd.  By default, babeld creates a pidfile, which can be disabled
>>  with "-I ''" on babeld's command line.  Unfortunately, it turns out that
>>  procd is unable to pass an empty argument to babeld.]
>>
>>> There lies the rub. If you have a deployed machine on a rooftop
>>> somewhere, it is better to restart the daemon automagically and log the
>>> action rather than attempt to debug it.
>> We're in full agreement here.  Babeld shouldn't crash, ever.  However,
>> should it crash, the crash should be logged somewhere and babeld restarted.
>>
>> As Gabriel mentioned, the issue is with procd being unable to pass an
>> empty argument.  A simple workaround would be to hack babeld to interpret
>> "-I none" as a synonym of "-I ''", but this issue should really be fixed
>> in procd.
>>
>> So, folks, please:
>>
>>  1. file a bug against procd;


i did not actually read the thread, but if there is a bug i would like
to know regardless of wonky /dev/null workarounds ... so procd refuses
to start service instances with no cmdline parameters ? or did i
understand the bug incorrectly?

additionally i recommend respawn + setting procd to generate core dumps
for babel if the daemon is flaky.

if the log output upon crash is not verbose enough we can make it more
apparent if bable crashed.
  
 


>>  2. provide me with a useful report if you manage to get babeld to crash;

core dumps ftw

>>  3. let me know if you want me to implement the "-I none" hack in babeld
>>     and release it as 1.5.2; it will cost you one beer, non tax-deductible.
> Cheap at the price. I note that merely treating an argument of /dev/null
> specially communicates the intent to not create a pidfile.
>
>> -- Juliusz
>>
>> P.S. Baptiste, please forward this mail to openwrt-devel, which pitylessly
>>      rejects my mails.
>
>
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel