[OpenWrt-Devel] [PATCH] brcm47xx: move wrt610n_v2 and e3000_v1 to mips74k subtarget

[Nathan Hintz]

Hi Rafał:

> Date: Sat, 18 Oct 2014 23:13:45 +0200
> Subject: Re: [PATCH] brcm47xx: move wrt610n_v2 and e3000_v1 to mips74k subtarget
> From: zajec5 at gmail.com
> To: nlhintz at hotmail.com
> CC: openwrt-devel at lists.openwrt.org; hauke at hauke-m.de
> 
> On 18 October 2014 22:37, Nathan Hintz <nlhintz at hotmail.com> wrote:
> >
> > Hi Rafał:
> >
> >> Date: Sat, 18 Oct 2014 21:28:29 +0200
> >> Subject: Re: [PATCH] brcm47xx: move wrt610n_v2 and e3000_v1 to mips74k
> >> subtarget
> >> From: zajec5 at gmail.com
> >> To: nlhintz at hotmail.com
> >> CC: openwrt-devel at lists.openwrt.org; hauke at hauke-m.de
> >
> >>
> >> On 18 October 2014 21:08, Nathan Hintz <nlhintz at hotmail.com> wrote:
> >> > - # BCMA SoC with SSB WiFi
> >> > - $(call Image/Build/CyberTAN,$(1),wrt610n_v2,610N,2.0.0,$(patsubst
> >> > jffs2-%,jffs2,$(1)))
> >> > - $(call Image/Build/CyberTAN,$(1),e3000_v1,61XN,1.0.3,$(patsubst
> >> > jffs2-%,jffs2,$(1)))
> >>
> >> They are there for a reason and there is even a comment for that!
> >
> > Can you be more explicit as to why they are an exception?
> 
> Same to you about commit messages ;)

I wasn't trying to be snarky; but that's OK.  I'm just looking for info and to further the discussion. :-)

> 
> 
> > Neither are "SSB Wifi"
> 
> They are.
> 
> https://wikidevi.com/wiki/Linksys_WRT610N_v2
> BCM4322 which is SSB based
> 
> https://wikidevi.com/wiki/Linksys_E3000
> BCM4322 which is SSB based
> 

I see your point; however, the E3000 and WRT610Nv2 are mips74k, and would get the same
benefit from using the mips74k subtarget (mips32r2) as all of the others.  The only difference
that I can see is that the E3000 and WRT610nV2 are required to use the proprietary
Broadcom wl driver (which is one of the supported profiles under the mips74k subtarget) in
order to utilize the 5GHz radio; whereas, with at least some of the others, using the proprietary
Broadcom wl driver is optional.  I could modify the patch description to include this info and to
keep the "SSB Wifi" comment if you think it is necessary.

> 
> > and I have
> > installed the mips74k trx with the broadcom_wl
> 
> wl.ko doesn't use kernel ssb/bcma modules

Nathan
 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20141018/63626a70/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel