[OpenWrt-Devel] [PATCH] [package] hostapd: vlan bridge naming inconsistent

[Felix Fietkau]

On 2014-09-28 14:37, Jon Agland wrote:
> VLAN bridge naming is inconsistent when using LuCI and trying to do 
> dynamic VLANs with OpenWRT (hostapd).
> 
> hostapd tries to use brvlanyyy but LuCI only creates br-vlanyyy (when 
> you use vlanyyy and select bridge)
> 
> This minor patch resolves this issue, so that you can use Dynamic VLAN 
> support with VLAN Naming disabled.  I've also just submitted a patch for 
> LuCI to support dynamic VLANs - 
> https://lists.subsignal.org/pipermail/luci/2014-September/001570.html
> 
> This needs to be applied to 
> trunk/package/network/services/hostapd/files/netifd.sh
> 
> Signed-off-by: Jon Agland <jon at sftwales.com>
> 
> --- src/netifd.sh    2014-09-28 13:18:54.246081887 +0100
> +++ vlan/netifd.sh    2014-09-28 13:20:30.114085964 +0100
> @@ -262,6 +262,11 @@
>                   [ -n "$vlan_tagged_interface" ] && \
>                       append bss_conf 
> "vlan_tagged_interface=$vlan_tagged_interface" "$N"
>               }
> +
> +                        if [ "$dynamic_vlan" -gt 0 ] && [ 
> "$vlan_naming" -eq 0 ]; then
> +                                append bss_conf "vlan_bridge=br-vlan" "$N"
> +                        fi
> +
Several issues with that patch:
- The path is wrong, you should use git or svn to generate the diff.
- the vlan_bridge value should be defined in the config, not hardcoded
- Your mail client has messed up the patch through line wrapping and
whitespace mangling.

Please fix and resend.

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel