[OpenWrt-Devel] [PATCH v2 3/3] hostapd: Add uapsd option to netifd.sh

[Vittorio G (VittGam)]

  Hi Felix,

Sorry for the late reply.

I've seen the check is already
implemented here in hostapd since 2011:
http://w1.fi/cgit/hostap/commit/?id=70619a5d8a3d32faa43d66bcb1b670cacf0c243e

So
maybe we should just set uapsd as default enabled, and let hostapd
check the actual support.

Do you think this would be
fine?

Cheers,
Vittorio

Il 18.10.2014 21:37 Felix Fietkau ha scritto:


> On 2014-10-14 20:05, Vittorio G (VittGam) wrote:
> 
>> The uapsd
option sets the uapsd_advertisement_enabled flag in hostapd, only if the
phy actually supports the option. Signed-off-by: Vittorio Gambaletta ---
package/network/services/hostapd/files/netifd.sh | 9 +++++++-- 1 file
changed, 7 insertions(+), 2 deletions(-) diff --git
a/package/network/services/hostapd/files/netifd.sh
b/package/network/services/hostapd/files/netifd.sh index
ccea5ff..48bcc9d 100644 ---
a/package/network/services/hostapd/files/netifd.sh +++
b/package/network/services/hostapd/files/netifd.sh
> 
>> @@ -189,6
+190,10 @@ hostapd_set_bss_options() { append bss_conf
"wmm_enabled=$wmm" "$N" append bss_conf "ignore_broadcast_ssid=$hidden"
"$N" + [ -n "$phy" ] && iw phy "$phy" info 2>/dev/null | grep -q 'Device
supports AP-side u-APSD.' && { + append bss_conf
"uapsd_advertisement_enabled=$uapsd" "$N" + }
> 
> hostapd's netifd.sh
should not hardcode cfg80211/mac80211 specific
> calls, it may be called
from other drivers in the future.
> 
> - Felix
 

Links:
------
[1]
mailto:openwrt at vittgam.net
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20141114/b015ef62/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel