[OpenWrt-Devel] [PATCH 00/17] atheros: checkpatch fixes

[Florian Fainelli]

2014-06-24 12:15 GMT-07:00 Daniel Gimpelevich
<daniel at gimpelevich.san-francisco.ca.us>:
> This is much appreciated, but what is really needed for upstream merge
> is converting the target to device tree usage.

Well, that is all debatable, Device Tree only makes sense if there are:

- new platforms/SoCs variants/boards being productized
- there is potential driver re-usability with another platform
- there is code duplication in the existing code base

I think AR231x has none of those, it's an End of Life platform, the
code base has been mostly static and well know for a while, so I would
argue that Device Tree should not be made a requirement here as it
will just delay Sergey's upstreaming effort even more.

Most people working on enforcing Device Tree (especially in the ARM
world) never really had to support an entire line of SoCs and try to
get that upstream, or even transitioning from a non-DT kernel to a
DT-aware. When Device Tree is there from day 1, it's easy to adopt and
model the rest of the code against it, when it's not, and your code
has been working and self-contained, this is mostly like rewriting
stuff from scratch, for a benefit that is close to zero.

Also, MIPS does not have any multi-platform kernels, so using Device
Tree might make even less sense here for such old platforms that are
submitted just so we get maintenance "for free".

>
> On Tue, 2014-06-10 at 04:29 +0400, Sergey Ryazanov wrote:
>> This series is an attempt to cleanup checkpatch generated warnings and errors
>> to make AR231x patches suitable for upstream merge.
>>
>> Sergey Ryazanov (17):
>>   atheros: avoid CamelCase
>>   atheros: various comments fixes
>>   atheros: parenthesis around complex macroses value
>>   atheros: remove parentheses around return values
>>   atheros: do not assignment in if condition
>>   atheros: remove trailing whitespace
>>   atheros: do not initialize statics to 0 or false
>>   atheros: various braces fixes
>>   atheros: various printk(...) fixes
>>   atheros: fix includes
>>   atheros: indent fixes
>>   atheros: spaces fixes
>>   atheros: trailing statements fixes
>>   atheros: avoid __FUNCTION__ usage
>>   atheros: constify some static structures
>>   atheros: shorten lines
>>   atheros: fix too short msleep
>>
>>  target/linux/atheros/patches-3.10/100-board.patch  | 864 +++++++++++----------
>>  .../patches-3.10/101-early-printk-support.patch    |   8 +-
>>  .../atheros/patches-3.10/105-ar2315_pci.patch      |  64 +-
>>  .../atheros/patches-3.10/110-ar2313_ethernet.patch | 369 ++++-----
>>  .../linux/atheros/patches-3.10/120-spiflash.patch  |  68 +-
>>  .../linux/atheros/patches-3.10/130-watchdog.patch  |  85 +-
>>  .../patches-3.10/140-redboot_boardconfig.patch     |  14 +-
>>  .../patches-3.10/141-redboot_partition_scan.patch  |   4 +-
>>  .../142-redboot_various_erase_size_fix.patch       |  12 +-
>>  .../atheros/patches-3.10/210-reset_button.patch    |   4 +-
>>  .../patches-3.10/220-enet_micrel_workaround.patch  |  28 +-
>>  .../atheros/patches-3.10/230-3_10-updates.patch    |  10 +-
>>  12 files changed, 781 insertions(+), 749 deletions(-)
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

-- 
Florian
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel