[OpenWrt-Devel] [PATCH] base-files: Use the same LED timing as before for preinit_regular.

[Vittorio G (VittGam)]

On 26 December 2014 at 09:53, Rafał Miłecki <zajec5 at gmail.com> wrote:
> On 26 December 2014 at 09:51, Rafał Miłecki <zajec5 at gmail.com> wrote:
>> On 25 December 2014 at 02:28, Vittorio G (VittGam) 
>> <openwrt at vittgam.net> wrote:
>>> Signed-off-by: Vittorio Gambaletta <openwrt at vittgam.net>
>>>
>>> diff --git a/package/base-files/files/lib/functions/leds.sh 
>>> b/package/base-files/files/lib/functions/leds.sh
>>> index 4ac8145..d4d4512 100644
>>> --- a/package/base-files/files/lib/functions/leds.sh
>>> +++ b/package/base-files/files/lib/functions/leds.sh
>>> @@ -60,7 +60,7 @@ status_led_blink_fast() {
>>>  }
>>>
>>>  status_led_blink_preinit() {
>>> -       led_timer $status_led 200 200
>>> +       led_timer $status_led 100 100
>>>  }
>>>
>>>  status_led_blink_failsafe() {
>>> @@ -68,5 +68,5 @@ status_led_blink_failsafe() {
>>>  }
>>>
>>>  status_led_blink_preinit_regular() {
>>> -       led_timer $status_led 500 500
>>> +       led_timer $status_led 200 200
>>>  }
>>
>> 1) Why?
>> 2) Explain "as before"
>> 3) I don't think there is enough difference between 100ms and 200ms
>
> 4) You don't mention  status_led_blink_preinit(), but your patch also 
> touches it

1) I think that most OpenWrt users, like me, are accustomed to see a 
led pattern of 200ms. I thought it was a bad flash or something else bad 
when I've seen that 500ms blinking...
2) "As before" means that when failsafe is possible, it is indicated by 
a new pattern of 100ms. When it is not possible anymore, the 
"classic"/previous 200ms pattern is used.
3) IMHO there is. It is visible enough for the user to know if it's 
possible to enter failsafe or not, while it is not disturbing for being 
too slow like the new 500ms.
4) Already explained in point 2, I think.

Cheers,
Vittorio G
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel