[OpenWrt-Devel] [PATCH 4/4] netifd: Add igmpversion config support

[Hans Dedecker]

On Wed, Dec 3, 2014 at 11:23 AM, Steven Barth <cyrus at openwrt.org> wrote:

> On 03.12.2014 11:15, Hans Dedecker wrote:
>
>> Config support to force the IGMP host version on device level; possible
>> values are:
>>      1|igmpv1: IGMP version 1
>>      2|igmpv2: IGMP version 2
>>      3|igmpv3: IGMP version 3
>>
>
>
> Thanks Hans.
>
> However, I don't really see the point of the string logic, it seems a bit
> bloated and the simple integer 1 2 or 3 should suffice imo.
>
> Also I'm wondering if this should set MLD version too (i.e. 1 if IGMP is 2
> and 2 if IGMP is 3).
>
> Cheers,
>
> Steven

I will simplify the configuration format and restrict it to the numerical
format as requested by you and Felix.
Regarding the MLD version wouldn't it be preferable to have this as a
different UCI parameter as I could imagine different versions in use for
MLD and IGMP. Quite a lot of ISP's are still stuck to IGMPv2 in their
network while they're using MLDv2 for IPV6.

Hans
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20141203/03c42ac4/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel