[OpenWrt-Devel] [PATCH] mac80211: fix WARN_ON_ONCE() caused by inbalanced set/clear of beacon enable bit.

John Crispin blogic at openwrt.org
Mon Aug 25 02:24:08 EDT 2014


Hi,

On 25/08/2014 05:29, Yousong Zhou wrote:
> +-			/* +-			 * Upload beacon to the H/W. This is only required on 
> +-			 * USB devices. PCI devices fetch beacons periodically. +-
> */ +-			if (rt2x00_is_usb(rt2x00dev)) +-
> rt2x00queue_update_beacon(rt2x00dev, vif); ++
> rt2x00queue_update_beacon(rt2x00dev, vif); +


this bit looks like someone intentionally added the comment to prevent
us from removing the if () clause. are you sure that removing it is
correct ?

	John
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list