[OpenWrt-Devel] [PATCH] PKG_CHECK_FORMAT_SECURITY: add a menuconfig option, disable by default

[John Crispin]

On 15/08/2014 08:56, Etienne CHAMPETIER wrote:
> The idea is still to enable it by default at some point I've tested
> all ar71xx packages (except oldpackages) using CONFIG_ALL=y Failing
> packages have been marked with PKG_CHECK_FORMAT_SECURITY:=0 for
> now I can test more targets but i have no idea which are the most
> used
> 

Hi Etienne,

sorry for the late feedback ...

I agree that we want this enabled by default. i know that lantiq will
fail for its dsl drivers if we do so.

i have taken the patch as is and will push in a sec. once BB finals
are out the door i will use the build machines to verify that all
packages build on all targets and then set the default to y

	John




> Signed-off-by: Etienne CHAMPETIER <champetier.etienne at gmail.com> 
> --- config/Config-build.in | 9 +++++++++ include/package.mk     | 8
> +++++--- 2 files changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/config/Config-build.in b/config/Config-build.in index
> 371ae76..02fe136 100644 --- a/config/Config-build.in +++
> b/config/Config-build.in @@ -93,6 +93,15 @@ menu "Global build
> settings"
> 
> If you are unsure, select N.
> 
> +	config PKG_CHECK_FORMAT_SECURITY +		bool +		prompt "Enable gcc
> format-security" +		default n +		help +		  Add -Wformat
> -Werror=format-security to the CFLAGS +		  You can disable this per
> package by adding +		  PKG_CHECK_FORMAT_SECURITY:=0 in the package
> Makefile + config PKG_BUILD_USE_JOBSERVER bool prompt "Use
> top-level make jobserver for packages" diff --git
> a/include/package.mk b/include/package.mk index 88ec3ef..1cdab6b
> 100644 --- a/include/package.mk +++ b/include/package.mk @@ -14,7
> +14,7 @@ PKG_INSTALL_DIR ?= $(PKG_BUILD_DIR)/ipkg-install 
> PKG_MD5SUM ?= unknown PKG_BUILD_PARALLEL ?= PKG_USE_MIPS16 ?= 1 
> -PKG_CHECK_FORMAT_SECURITY ?= 0 +PKG_CHECK_FORMAT_SECURITY ?= 1
> 
> ifneq ($(CONFIG_PKG_BUILD_USE_JOBSERVER),) MAKE_J:=$(if
> $(MAKE_JOBSERVER),$(MAKE_JOBSERVER) -j) @@ -34,8 +34,10 @@ ifdef
> CONFIG_USE_MIPS16 TARGET_CFLAGS += -mips16 -minterlink-mips16 
> endif endif -ifeq ($(strip $(PKG_CHECK_FORMAT_SECURITY)),1) -
> TARGET_CFLAGS += -Wformat -Werror=format-security +ifdef
> CONFIG_PKG_CHECK_FORMAT_SECURITY +  ifeq ($(strip
> $(PKG_CHECK_FORMAT_SECURITY)),1) +    TARGET_CFLAGS += -Wformat
> -Werror=format-security +  endif endif
> 
> include $(INCLUDE_DIR)/prereq.mk
> 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel